Experiment with getting reformatted chunks from Black #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaihola
changed the title
akaihola
force-pushed
the
chunks-from-black
branch
from
e4166da
to
d3ebb66
Compare
akaihola
force-pushed
the
chunks-from-black
branch
3 times, most recently
from
b05e066
to
77de983
Compare
akaihola
force-pushed
the
chunks-from-black
branch
from
77de983
to
5ebb466
Compare
akaihola
force-pushed
the
chunks-from-black
branch
3 times, most recently
from
3f7ce48
to
2bdfe00
Compare
akaihola
added
help wanted
|
I think I ran into a dead end and started to doubt whether this can be done at all. |
akaihola
force-pushed
the
chunks-from-black
branch
3 times, most recently
from
60f1eaf
to
85d2b50
Compare
akaihola
force-pushed
the
chunks-from-black
branch
3 times, most recently
from
9000497
to
55a8138
Compare
akaihola
force-pushed
the
chunks-from-black
branch
3 times, most recently
from
89a9272
to
6204862
Compare
akaihola
force-pushed
the
chunks-from-black
branch
2 times, most recently
from
b0b2cd5
to
b75d818
Compare
akaihola
force-pushed
the
chunks-from-black
branch
4 times, most recently
from
9ed96ee
to
4a524b0
Compare
akaihola
force-pushed
the
chunks-from-black
branch
3 times, most recently
from
f7765ec
to
478688a
Compare
akaihola
force-pushed
the
chunks-from-black
branch
from
478688a
to
3f1222c
Compare
akaihola
force-pushed
the
chunks-from-black
branch
3 times, most recently
from
9af2dea
to
ff28a33
Compare
akaihola
force-pushed
the
chunks-from-black
branch
2 times, most recently
from
71bf232
to
1e9859b
Compare
akaihola
force-pushed
the
chunks-from-black
branch
from
1e9859b
to
f6f8021
Compare
This is an experiment. Still concatenates the lines afterwards without making any use of the extra information we could get.
This should allow us to get smaller diff chunks from Black than by diffing and analyzing Black's string output for whole files.
akaihola
force-pushed
the
chunks-from-black
branch
from
f6f8021
to
582fa74
Compare
akaihola
modified the milestones:
Darker 1.8.0 – Flynt compatibility,
Darker 1.9.0 – Graylint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By getting results of reformatting from Black in chunks instead of complete files, we should be able to apply reformat modified sections with more granularity.
This is an experiment and to be considered carefully, since it involves re-implementing parts of Black, and will be sensitive to internal changes in Black versions.